Skip to content

Default CMAKE_SYSTEM_PROCESSOR to the host #10912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 15, 2025

Summary

Although by default cmake use the host's architecture if CMAKE_SYSTEM_PROCESSOR isn't provided, it doesn't actually set the value. This can be an issue in cases where people try to read this value (i.e. extension/llm/custom_ops/CMakeLists.txt). So, let's just explicitly set it.

Test plan

CI

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 15, 2025
Copy link

pytorch-bot bot commented May 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10912

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 31a61d2 with merge base 47164cc (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2025
@jathu jathu marked this pull request as ready for review May 15, 2025 17:51
@jathu jathu merged commit a63a648 into main May 15, 2025
195 of 196 checks passed
@jathu jathu deleted the jathu/default-processor branch May 15, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants