Fix CatFromSliceCopyPass indexing issue. #10913
Merged
+101
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10913
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 4d7d174 with merge base 56eb18b ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74765369 |
|
@pytorchbot label "topic: not user facing" |
abeakkas
added a commit
to abeakkas/executorch
that referenced
this pull request
May 15, 2025
Summary: Fix indexing bug in RemoveCatFromSliceCopyPass. If the slice input becomes one of the later inputs of the cat the slicing indices should be updated accordingly. Also simplify the pass and generalize arg/kwarg support. Differential Revision: D74765369
abeakkas
force-pushed
the
export-D74765369
branch
from
9fcf1b4 to
0852980
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74765369 |
abeakkas
added a commit
to abeakkas/executorch
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: pytorch#10913 Fix indexing bug in RemoveCatFromSliceCopyPass. If the slice input becomes one of the later inputs of the cat the slicing indices should be updated accordingly. Also simplify the pass and generalize arg/kwarg support. Differential Revision: D74765369
abeakkas
force-pushed
the
export-D74765369
branch
from
0852980 to
a12c7b7
Compare
zonglinpeng
approved these changes
May 15, 2025
abeakkas
added a commit
to abeakkas/executorch
that referenced
this pull request
May 15, 2025
Summary: Fix indexing bug in RemoveCatFromSliceCopyPass. If the slice input becomes one of the later inputs of the cat the slicing indices should be updated accordingly. Also simplify the pass and generalize arg/kwarg support. Reviewed By: zonglinpeng Differential Revision: D74765369
abeakkas
force-pushed
the
export-D74765369
branch
from
a12c7b7 to
d1a1bce
Compare
Summary: Pull Request resolved: pytorch#10913 Fix indexing bug in RemoveCatFromSliceCopyPass. If the slice input becomes one of the later inputs of the cat the slicing indices should be updated accordingly. Also simplify the pass and generalize arg/kwarg support. Reviewed By: zonglinpeng Differential Revision: D74765369
|
This pull request was exported from Phabricator. Differential Revision: D74765369 |
abeakkas
force-pushed
the
export-D74765369
branch
from
d1a1bce to
4d7d174
Compare
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix indexing bug in RemoveCatFromSliceCopyPass. If the slice input becomes one of the later inputs of the cat the slicing indices should be updated accordingly.
Also simplify the pass and generalize arg/kwarg support.
Differential Revision: D74765369