Skip to content

Arm backend: test_conformer.py emergency fix #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented May 16, 2025

Summary

Some tests was changed from expected fail to pass in a recent PR but they turned out to not work.
Lets back them out again and investigate.
This make the unittest-arm-backend-with-no-fvp (test_pytest_models) test work again.

Test plan

By hand and in GitHub

We enabled some new tests in this suite but they turend out to not
work, lest back it out again and investigate.
This make the unittest-arm-backend-with-no-fvp (test_pytest_models)
test work again.

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: I16580299bcd94cd5d7c2146a1759554d0026f4c6
@zingo zingo requested a review from digantdesai as a code owner May 16, 2025 19:44
Copy link

pytorch-bot bot commented May 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10950

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit 5adf760 with merge base d0848ca (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2025
@zingo zingo added ciflow/trunk module: arm Issues related to arm backend release notes: none Do not include this in the release notes labels May 16, 2025
@zingo
Copy link
Collaborator Author

zingo commented May 16, 2025

Hmm this is probably not the proper fix. Tests pass sometime som Im wondering if it's a rosource problem as we run the models on the same machine in parallell. Need to test some more.

@zingo zingo marked this pull request as draft May 18, 2025 07:44
@zingo
Copy link
Collaborator Author

zingo commented May 21, 2025

This was not a problem, close without merge

@zingo zingo closed this May 21, 2025
@zingo zingo deleted the Arm-backend-test_conformer.py-emergency-fix branch June 9, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants