delete stuff from pybindings.cpp #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48577067 |
|
This pull request was exported from Phabricator. Differential Revision: D48577067 |
JacobSzwejbka
force-pushed
the
export-D48577067
branch
from
01352f3 to
d78459e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48577067 |
JacobSzwejbka
force-pushed
the
export-D48577067
branch
from
d78459e to
4d272c6
Compare
Summary: Pull Request resolved: pytorch/executorch#110 Dont think any of this stuff Im deleting is used. It exposes flatbuffer internals which is bad so deleting. I think the remaining stuff is just utils for selective build so we should move this out of exetensions so regular users cant see it. Reviewed By: tarun292 Differential Revision: D48577067 fbshipit-source-id: b3c3702c125c6cd7e5b45b645802c072f309e613
|
This pull request was exported from Phabricator. Differential Revision: D48577067 |
JacobSzwejbka
force-pushed
the
export-D48577067
branch
from
4d272c6 to
dc926ea
Compare
|
This pull request has been merged in fbb960b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Dont think any of this stuff Im deleting is used. It exposes flatbuffer internals which is bad so deleting.
I think the remaining stuff is just utils for selective build so we should move this out of exetensions so regular users cant see it.
Differential Revision: D48577067