Introduce hydra framework with backwards compatibility #11029

jackzhxng · 2025-05-21T00:43:20Z

Stack from ghstack (oldest at bottom):

Differential Revision: D75263989

[ghstack-poisoned]

pytorch-bot · 2025-05-21T00:43:24Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11029

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit bfd2dec with merge base c2aa614 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / test-models-linux (linear, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 3e26c22 Pull Request resolved: #11029

[ghstack-poisoned]

ghstack-source-id: 20a87fd Pull Request resolved: #11029

[ghstack-poisoned]

ghstack-source-id: 6009f90 Pull Request resolved: #11029

[ghstack-poisoned]

jackzhxng · 2025-05-23T01:28:03Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jackzhxng · 2025-05-27T15:28:43Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jackzhxng · 2025-05-27T22:31:40Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

jackzhxng · 2025-05-27T22:35:18Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jackzhxng · 2025-05-27T23:46:21Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-06-05T15:45:04Z

This pull request was exported from Phabricator. Differential Revision: D75263989

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

facebook-github-bot · 2025-06-05T18:56:25Z

This pull request was exported from Phabricator. Differential Revision: D75263989

examples/models/llama/TARGETS

examples/models/llama/config/llm_config_utils.py

examples/models/llama/config/targets.bzl

examples/models/llama/export_llama_args.py

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

facebook-github-bot · 2025-06-06T21:24:37Z

This pull request was exported from Phabricator. Differential Revision: D75263989

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

facebook-github-bot · 2025-06-06T21:40:06Z

This pull request was exported from Phabricator. Differential Revision: D75263989

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

Pull Request resolved: #11029 @imported-using-ghimport Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989/) ghstack-source-id: 288807821

facebook-github-bot · 2025-06-06T22:15:40Z

This pull request was exported from Phabricator. Differential Revision: D75263989

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

facebook-github-bot · 2025-06-09T19:56:08Z

This pull request was exported from Phabricator. Differential Revision: D75263989

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

facebook-github-bot · 2025-06-09T20:56:53Z

This pull request was exported from Phabricator. Differential Revision: D75263989

@jackzhxng

This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11029 by @jackzhxng ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/11/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/11/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/10/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/11/orig @diff-train-skip-merge --------- Co-authored-by: Jack Zhang <[email protected]>

kimishpatel · 2025-06-10T18:27:40Z

examples/models/llama/export_llama.py

+        # The import runs the main function of export_llama_hydra with the remaining args
+        # under the Hydra framework.
+        sys.argv = [arg for arg in sys.argv if arg != "--hydra"]
+        print(f"running with {sys.argv}")


did you mean to print this?

kimishpatel · 2025-06-10T18:27:59Z

examples/models/llama/export_llama.py

+        # under the Hydra framework.
+        sys.argv = [arg for arg in sys.argv if arg != "--hydra"]
+        print(f"running with {sys.argv}")
+        runpy.run_module(


not just use importlib?

oh nevermind. you are running this module not importing it

kimishpatel · 2025-06-10T18:29:50Z

examples/models/llama/export_llama_hydra.py

+cs.store(name="llm_config", node=LlmConfig)
+
+
+@hydra.main(version_base=None, config_name="llm_config")


i dont think i know enough about hydra but is there a test that showcases the use?

ghstack-source-id: 3f0d943 Pull Request resolved: pytorch/executorch#11029

ghstack-source-id: 854baa2 Pull Request resolved: pytorch/executorch#11029

Introduce hydra framework with backwards compatibility

673e39f

[ghstack-poisoned]

jackzhxng requested a review from lucylq as a code owner May 21, 2025 00:43

jackzhxng mentioned this pull request May 21, 2025

Add new export LLM config #11028

Merged

jackzhxng added a commit that referenced this pull request May 21, 2025

Introduce hydra framework with backwards compatibility

9bbae13

ghstack-source-id: 3e26c22 Pull Request resolved: #11029

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2025

Update on "Introduce hydra framework with backwards compatibility"

c48b67e

[ghstack-poisoned]

jackzhxng added a commit that referenced this pull request May 22, 2025

Introduce hydra framework with backwards compatibility

7f0e60e

ghstack-source-id: 20a87fd Pull Request resolved: #11029

Update on "Introduce hydra framework with backwards compatibility"

ae14d3e

[ghstack-poisoned]

jackzhxng added a commit that referenced this pull request May 22, 2025

Introduce hydra framework with backwards compatibility

cdcac9f

ghstack-source-id: 6009f90 Pull Request resolved: #11029

Update on "Introduce hydra framework with backwards compatibility"

f8fc412

[ghstack-poisoned]

This was referenced May 22, 2025

Convert args to LlmConfig #11081

Merged

Use llm_config instead of args in export_llama functions #11084

Closed

jackzhxng added 2 commits May 22, 2025 17:39

Update on "Introduce hydra framework with backwards compatibility"

44fa6dc

[ghstack-poisoned]

Update on "Introduce hydra framework with backwards compatibility"

6c6cf65

[ghstack-poisoned]

jackzhxng added the release notes: none Do not include this in the release notes label May 23, 2025

jackzhxng mentioned this pull request May 27, 2025

Use llm_config instead of args in export_llama functions #11162

Merged

Update on "Introduce hydra framework with backwards compatibility"

c501c37

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

jackzhxng linked an issue Jun 5, 2025 that may be closed by this pull request

[etLLM] New config system to export_llama #9449

Closed

Update on "Introduce hydra framework with backwards compatibility"

4dd719d

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

larryliu0820 reviewed Jun 6, 2025

View reviewed changes

examples/models/llama/TARGETS Outdated Show resolved Hide resolved

larryliu0820 reviewed Jun 6, 2025

View reviewed changes

examples/models/llama/config/llm_config_utils.py Outdated Show resolved Hide resolved

larryliu0820 reviewed Jun 6, 2025

View reviewed changes

examples/models/llama/config/targets.bzl Outdated Show resolved Hide resolved

larryliu0820 reviewed Jun 6, 2025

View reviewed changes

examples/models/llama/export_llama_args.py Show resolved Hide resolved

Update on "Introduce hydra framework with backwards compatibility"

5fe7814

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

Update on "Introduce hydra framework with backwards compatibility"

f98618d

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

Update on "Introduce hydra framework with backwards compatibility"

ea61786

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

larryliu0820 approved these changes Jun 6, 2025

View reviewed changes

Update on "Introduce hydra framework with backwards compatibility"

10c3aba

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

Update on "Introduce hydra framework with backwards compatibility"

bfd2dec

Differential Revision: [D75263989](https://our.internmc.facebook.com/intern/diff/D75263989) [ghstack-poisoned]

facebook-github-bot merged commit f557501 into gh/jackzhxng/11/base Jun 10, 2025
101 of 104 checks passed

facebook-github-bot deleted the gh/jackzhxng/11/head branch June 10, 2025 03:45

facebook-github-bot temporarily deployed to cherry-pick-bot June 10, 2025 03:45 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Jun 10, 2025

Introduce hydra framework with backwards compatibility #11512

Merged

kimishpatel reviewed Jun 10, 2025

View reviewed changes

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025

Introduce hydra framework with backwards compatibility

6f7a082

ghstack-source-id: 3f0d943 Pull Request resolved: pytorch/executorch#11029

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025

Introduce hydra framework with backwards compatibility

f402a9a

ghstack-source-id: 854baa2 Pull Request resolved: pytorch/executorch#11029

		cs.store(name="llm_config", node=LlmConfig)


		@hydra.main(version_base=None, config_name="llm_config")

Introduce hydra framework with backwards compatibility #11029

Introduce hydra framework with backwards compatibility #11029

Uh oh!

Conversation

jackzhxng commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11029

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

jackzhxng commented May 23, 2025

Uh oh!

jackzhxng commented May 27, 2025

Uh oh!

jackzhxng commented May 27, 2025

Uh oh!

jackzhxng commented May 27, 2025

Uh oh!

jackzhxng commented May 27, 2025

Uh oh!

facebook-github-bot commented Jun 5, 2025

Uh oh!

facebook-github-bot commented Jun 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

Uh oh!

kimishpatel Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

kimishpatel Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

kimishpatel Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

kimishpatel Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jackzhxng commented May 21, 2025 •

edited

Loading

pytorch-bot bot commented May 21, 2025 •

edited

Loading