Skip to content

Arm backend: Convert int pow to multiplications #11037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Conversation

per
Copy link
Collaborator

@per per commented May 21, 2025

Summary

Add a pass to convert integer pow to series of multiplications to handle square operations on negative values since TOSA 1.0 only allows values > 0 for its POW operation.

Test plan

Test on internal and external CI.

cc @digantdesai @freddan80 @zingo @oscarandersson8218

Add a pass to convert integer pow to series of multiplications to
handle square operations on negative values since TOSA 1.0 only
allows values > 0 for its POW operation.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I7218242abd59b67c008e29f748fd4319e32238cf
@per per requested a review from digantdesai as a code owner May 21, 2025 11:31
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing release notes: none Do not include this in the release notes labels May 21, 2025
Copy link

pytorch-bot bot commented May 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11037

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Pending

As of commit d953dba with merge base d8c26ee (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2025
@per
Copy link
Collaborator Author

per commented May 21, 2025

@zingo zingo merged commit 8d11ea6 into pytorch:main May 21, 2025
183 of 184 checks passed
@per per deleted the pow_to_muls branch May 21, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants