Skip to content

Convert args to LlmConfig #11081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 10, 2025
Merged

Convert args to LlmConfig #11081

merged 19 commits into from
Jun 10, 2025

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented May 22, 2025 •
edited
Loading

@jackzhxng
Convert args to LlmConfig
aed7c50 
[ghstack-poisoned]
@jackzhxng jackzhxng requested a review from lucylq as a code owner May 22, 2025 22:36
This was referenced May 22, 2025
Merged
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11081

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c5b956c with merge base c2aa614 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2025
jackzhxng added a commit that referenced this pull request May 22, 2025
@jackzhxng
Convert args to LlmConfig
b02cdce 
ghstack-source-id: f219b29
Pull Request resolved: #11081
@jackzhxng jackzhxng mentioned this pull request May 22, 2025
Closed
@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label May 23, 2025
@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng jackzhxng mentioned this pull request May 27, 2025
Merged
@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

This was referenced May 27, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng jackzhxng mentioned this pull request May 28, 2025
Closed
@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@jackzhxng jackzhxng linked an issue Jun 5, 2025 that may be closed by this pull request
[etLLM] New config system to export_llama #9449
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@jackzhxng jackzhxng requested a review from shoumikhin as a code owner June 9, 2025 19:55
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

@facebook-github-bot facebook-github-bot merged commit a2413d4 into gh/jackzhxng/12/base Jun 10, 2025
103 of 104 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/jackzhxng/12/head branch June 10, 2025 03:45
@pytorchbot pytorchbot mentioned this pull request Jun 10, 2025
Merged
jackzhxng added a commit that referenced this pull request Jun 10, 2025
@pytorchbot @jackzhxng
Convert args to LlmConfig (#11513)
954f0e9 
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #11081 by
@jackzhxng
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/12/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/12/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/11/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/12/orig
@diff-train-skip-merge

---------

Co-authored-by: Jack Zhang <[email protected]>
kimishpatel
kimishpatel reviewed Jun 10, 2025
View reviewed changes
examples/models/llama/config/llm_config.py
"""
To support legacy purposes, this function converts CLI args from
argparse to an LlmConfig, which is used by the LLM export process.
"""
llm_config = LlmConfig()

# TODO: conversion code.
# BaseConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should definitely vet what of those original args are worth keeping

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@jackzhxng
Convert args to LlmConfig
045a968 
ghstack-source-id: 88021d9
Pull Request resolved: pytorch/executorch#11081
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@jackzhxng
Convert args to LlmConfig
4839cc1 
ghstack-source-id: c8ffa7f
Pull Request resolved: pytorch/executorch#11081
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@jackzhxng
Convert args to LlmConfig
f225461 
Pull Request resolved: pytorch/executorch#11081




@imported-using-ghimport

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990/)
ghstack-source-id: 287798913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel left review comments

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[etLLM] New config system to export_llama
4 participants
@jackzhxng @facebook-github-bot @larryliu0820 @kimishpatel