[cmake] Fix CI job #1112
Closed
[cmake] Fix CI job #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories.
To install these two libraries (`libexecutorch.a` and `libportable_kernels.a`), user needs to run:
```
cmake -DBUCK2="$BUCK" \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
-Bcmake-out .
cmake --build cmake-out -j9 --target install
```
Then in the console output we will have:
```
-- Installing: /home/larryliu/executorch/cmake-out/lib/libportable_kernels.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/libexecutorch.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/cmake/ExecuTorch/ExecuTorchConfig.cmake
```
In order to find these libraries, we can do the following in example CMakeLists.txt:
```
find_package(ExecuTorch REQUIRED)
```
Then the example CMakeLists.txt can depend on `executorch` and `portable_kernels`.
Reviewed By: dbort
Differential Revision: D50482400
Pulled By: larryliu0820
Summary: Fix an issue caused by #1036 Test Plan: Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1112
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue cased by #1036