Skip to content

Install libexecutorch.a and libportable_kernels.a (#1036) #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Oct 31, 2023

Stack from ghstack (oldest at bottom):

Summary:
This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories.

To install these two libraries (libexecutorch.a and libportable_kernels.a), user needs to run:

    cmake -DBUCK2="$BUCK" \
            -DCMAKE_INSTALL_PREFIX=cmake-out \
            -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
            -Bcmake-out .
    cmake --build cmake-out -j9 --target install

Then in the console output we will have:

-- Installing: /home/larryliu/executorch/cmake-out/lib/libportable_kernels.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/libexecutorch.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/cmake/ExecuTorch/ExecuTorchConfig.cmake

In order to find these libraries, we can do the following in example CMakeLists.txt:

find_package(ExecuTorch REQUIRED)

Then the example CMakeLists.txt can depend on executorch and portable_kernels.

Reviewed By: dbort

Differential Revision: D50482400

Pulled By: larryliu0820

Summary:
This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories.

To install these two libraries (`libexecutorch.a` and `libportable_kernels.a`), user needs to run:
```
    cmake -DBUCK2="$BUCK" \
            -DCMAKE_INSTALL_PREFIX=cmake-out \
            -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
            -Bcmake-out .
    cmake --build cmake-out -j9 --target install
```
Then in the console output we will have:

```
-- Installing: /home/larryliu/executorch/cmake-out/lib/libportable_kernels.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/libexecutorch.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/cmake/ExecuTorch/ExecuTorchConfig.cmake
```
In order to find these libraries, we can do the following in example CMakeLists.txt:

```
find_package(ExecuTorch REQUIRED)
```
Then the example CMakeLists.txt can depend on `executorch` and `portable_kernels`.


Reviewed By: dbort

Differential Revision: D50482400

Pulled By: larryliu0820

[ghstack-poisoned]
@larryliu0820 larryliu0820 mentioned this pull request Oct 31, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1113

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 375cbcb with merge base 7814dd7 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2023
@larryliu0820 larryliu0820 mentioned this pull request Oct 31, 2023
@facebook-github-bot facebook-github-bot deleted the gh/larryliu0820/1/head branch November 30, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants