Skip to content

Bump PyTorch pin to dev20250525 #11154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Bump PyTorch pin to dev20250525 #11154

wants to merge 7 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok
Update
72fb9b7 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented May 27, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11154

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 19 Pending

As of commit 0ef91c1 with merge base 2e9c71c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request May 27, 2025
@swolchok
Bump PyTorch pin to dev20250527
52f7d4e 
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 .


ghstack-source-id: 22ffb3e
ghstack-comment-id: 2913765876
Pull-Request-resolved: #11154
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2025
@swolchok swolchok added the release notes: none Do not include this in the release notes label May 27, 2025
swolchok added a commit that referenced this pull request May 27, 2025
@swolchok
Bump PyTorch pin to dev20250527
bb97369 
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 .

ghstack-source-id: 29d3e18
ghstack-comment-id: 2913765876
Pull-Request-resolved: #11154
@swolchok swolchok changed the title Bump PyTorch pin to dev20250527 Bump PyTorch pin to dev20250526 May 27, 2025
@swolchok
Update
d57b556 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 27, 2025
@swolchok
Bump PyTorch pin to dev20250527
a9b729d 
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 .

ghstack-source-id: 77ed4ba
ghstack-comment-id: 2913765876
Pull-Request-resolved: #11154
@swolchok swolchok changed the title Bump PyTorch pin to dev20250526 Bump PyTorch pin to dev20250525 May 27, 2025
@swolchok
Copy link
Contributor Author

can't import the name deprecated from typing_extensions. We must have a different version from pytorch/pytorch somehow?

swolchok added a commit that referenced this pull request May 28, 2025
@swolchok
Bump PyTorch pin to dev20250527
f7bc279 
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 .

ghstack-source-id: e4682b6
ghstack-comment-id: 2913765876
Pull-Request-resolved: #11154
@swolchok swolchok requested a review from GregoryComer as a code owner May 28, 2025 04:07
swolchok added a commit that referenced this pull request May 28, 2025
@swolchok
Bump PyTorch pin to dev20250527
00458e1 
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 .

ghstack-source-id: f7d6408
ghstack-comment-id: 2913765876
Pull-Request-resolved: #11154
@swolchok
rebase
f01ae31 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 28, 2025
@swolchok
Bump PyTorch pin to dev20250527
d56e6a6 
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 .

ghstack-source-id: 9cc878c
ghstack-comment-id: 2913765876
Pull-Request-resolved: #11154
@swolchok
Copy link
Contributor Author

can't import the name deprecated from typing_extensions. We must have a different version from pytorch/pytorch somehow?

Fixed; needed to update third-party/TARGETS not just the OSS build config.

@swolchok
Copy link
Contributor Author

test-llama-runner-mac failure using coreml seems real: https://github.com/pytorch/executorch/actions/runs/15291283923/job/43011123225?pr=11154#step:9:36325

CoreML folks @kimishpatel @YifanShenSZ @cymbalrush @metascroy any ideas?

@swolchok swolchok mentioned this pull request May 29, 2025
Closed
@swolchok
Copy link
Contributor Author

CoreML failures bisect to pytorch/pytorch#153795

@swolchok
Copy link
Contributor Author

swolchok commented Jun 3, 2025

coreml failure doesn't repro locally when I run bash .ci/scripts/test_llama.sh -model stories110M -build_tool cmake -dtype fp32 -mode coreml despite that being the failing command in CI.

@swolchok
Update
0ef91c1 
[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Jun 3, 2025
Merged
@swolchok
Copy link
Contributor Author

swolchok commented Jun 3, 2025

superseded by #11318

@swolchok swolchok closed this Jun 3, 2025
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
Bump PyTorch pin to dev20250527
116a775 
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 .

ghstack-source-id: 72d498c
ghstack-comment-id: 2913765876
Pull-Request-resolved: pytorch/executorch#11154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @JacobSzwejbka @facebook-github-bot