Used cmake-format on CMakeLists.txt #11230
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11230
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d225762 with merge base e84c319 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @BujSet! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
CMakeLists.txt
Outdated
| @@ -45,7 +45,8 @@ | |||
| cmake_minimum_required(VERSION 3.24) | |||
| project(executorch) | |||
|
|
|||
| # MARK: - Start EXECUTORCH_H12025_BUILD_MIGRATION -------------------------------------------------- | |||
| # MARK: - Start EXECUTORCH_H12025_BUILD_MIGRATION | |||
| # -------------------------------------------------- | |||
There was a problem hiding this comment.
| # -------------------------------------------------- |
CMakeLists.txt
Outdated
| @@ -82,24 +83,25 @@ include(${PROJECT_SOURCE_DIR}/tools/cmake/preset/default.cmake) | |||
| # Print all the configs that were called with announce_configured_options. | |||
| print_configured_options() | |||
|
|
|||
| # MARK: - End EXECUTORCH_H12025_BUILD_MIGRATION ---------------------------------------------------- | |||
| # MARK: - End EXECUTORCH_H12025_BUILD_MIGRATION | |||
| # ---------------------------------------------------- | |||
There was a problem hiding this comment.
| # ---------------------------------------------------- |
CMakeLists.txt
Outdated
| # the rpath (per library?) TODO: Doesn't work for us right now because we are | ||
| # not installing .so's into the correct locations. For example we have |
There was a problem hiding this comment.
I think we should keep the TODO as a separate paragraph like it was before
BujSet
requested review from
GregoryComer,
swolchok,
JacobSzwejbka,
lucylq,
cccclai,
mergennachin and
SS-JIA
as code owners
BujSet
force-pushed
the
formatting_cmakelists
branch
from
a0c9f12 to
1e72783
Compare
Removing unnecessary comment lines used for segmenting the file and splitting larger comments as they were before the cmake-format pass.
BujSet
force-pushed
the
formatting_cmakelists
branch
from
1e72783 to
d225762
Compare
Summary
Fixes #<10736>: #10736 (comment)Changes I Made
cmake-format -i CMakeLists.txtcmake-lint CMakeLists.txtThe linting reported an [E1122] Duplicate keyword argument error for variable DESTINATION. I deleted the earlier setting of this variable, as the comment seemed to imply that
libshould not be the appropriate destination.Test plan
Successfully ran the commands in the building from source guide. I did try running the test commands from the Testing, however, these reported error on a clean install. No new errors were reported when I made these changes.