Skip to content

Bump macOS deployment target to 12.0 #11247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Bump macOS deployment target to 12.0 #11247

merged 1 commit into from
May 30, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 30, 2025

Summary

We want to enable MPS AOT for macOS. This requires a minimum target deployment of 12.0. Example error:

2025-05-30T01:57:11.3334050Z /Users/runner/work/executorch/executorch/pytorch/executorch/backends/apple/mps/runtime/MPSGraphBuilder.mm:174:1: error: 'MPSGraphExecutable' is only available on macOS 12.0 or newer [-Werror,-Wunguarded-availability-new]
2025-05-30T01:57:11.3334100Z MPSGraphExecutable*
2025-05-30T01:57:11.3334140Z ^

Given 12.0 is already at end of life, are there any other problems with this increase?

Test plan

rg "10(\.|_)15" --hidden -g '!**/{third-party,.git}'

Copy link

pytorch-bot bot commented May 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11247

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0c4e95f with merge base b02ac1b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2025
@jathu jathu added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label May 30, 2025
@jathu jathu force-pushed the jathu/macos-12 branch from 4d5066d to 0c4e95f Compare May 30, 2025 03:50
@jathu jathu marked this pull request as ready for review May 30, 2025 13:54
@shoumikhin
Copy link
Contributor

shoumikhin commented May 30, 2025

Mind checking which version we use internally for Buck?
We can already remove some "@availabe(macOS 11" checks.
And potentially we may bump it even to 12.3 and remove some more of the @available checks.

@jathu
Copy link
Contributor Author

jathu commented May 30, 2025

I create a task to clean up checks below 12.0: #11259

@jathu jathu merged commit ceaf147 into main May 30, 2025
217 of 218 checks passed
@jathu jathu deleted the jathu/macos-12 branch May 30, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants