Skip to content

[ET-VK][ez] Updates to DynamicDispatchNode #11254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 2, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented May 30, 2025

Stack from ghstack (oldest at bottom):

Changes

  • Pass in global work group size to the local work group size determination function in DynamicDIspatchNode

Motivation

Oftentimes it is useful to know what the global work group size is when determining what the local group group size should be.

Performance Impact

None.

Differential Revision: D75686047

## Changes

* Pass in global work group size to the local work group size determination function in `DynamicDIspatchNode`

## Motivation

Oftentimes it is useful to know what the global work group size is when determining what the local group group size should be.

## Performance Impact

None.

Differential Revision: [D75686047](https://our.internmc.facebook.com/intern/diff/D75686047/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11254

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 39e5744 with merge base ce8359d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75686047

## Changes

* Pass in global work group size to the local work group size determination function in `DynamicDIspatchNode`

## Motivation

Oftentimes it is useful to know what the global work group size is when determining what the local group group size should be.

## Performance Impact

None.

Differential Revision: [D75686047](https://our.internmc.facebook.com/intern/diff/D75686047/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75686047

## Changes

* Pass in global work group size to the local work group size determination function in `DynamicDIspatchNode`

## Motivation

Oftentimes it is useful to know what the global work group size is when determining what the local group group size should be.

## Performance Impact

None.

Differential Revision: [D75686047](https://our.internmc.facebook.com/intern/diff/D75686047/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75686047

## Changes

* Pass in global work group size to the local work group size determination function in `DynamicDIspatchNode`

## Motivation

Oftentimes it is useful to know what the global work group size is when determining what the local group group size should be.

## Performance Impact

None.

Differential Revision: [D75686047](https://our.internmc.facebook.com/intern/diff/D75686047/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75686047

## Changes

* Pass in global work group size to the local work group size determination function in `DynamicDIspatchNode`

## Motivation

Oftentimes it is useful to know what the global work group size is when determining what the local group group size should be.

## Performance Impact

None.

Differential Revision: [D75686047](https://our.internmc.facebook.com/intern/diff/D75686047/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75686047

@trivedivivek trivedivivek added the release notes: vulkan Changes to the Vulkan backend delegate label May 30, 2025
## Changes

* Pass in global work group size to the local work group size determination function in `DynamicDIspatchNode`

## Motivation

Oftentimes it is useful to know what the global work group size is when determining what the local group group size should be.

## Performance Impact

None.

Differential Revision: [D75686047](https://our.internmc.facebook.com/intern/diff/D75686047/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75686047

## Changes

* Pass in global work group size to the local work group size determination function in `DynamicDIspatchNode`

## Motivation

Oftentimes it is useful to know what the global work group size is when determining what the local group group size should be.

## Performance Impact

None.

Differential Revision: [D75686047](https://our.internmc.facebook.com/intern/diff/D75686047/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75686047

@facebook-github-bot facebook-github-bot merged commit 44ba5f0 into gh/SS-JIA/230/base Jun 2, 2025
98 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/230/head branch June 2, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants