Make core aten exception ops modifiable at runtime. #11497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11497
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 1b812c3 with merge base 6a4df94 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75997936 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 9, 2025
Summary: Right now we run the ir verifier with a hardcoded set of whitelisted ops. This diff modifies the API to pass the user-defined ops to extend the exception list. See the attached task for more details. Differential Revision: D75997936
|
This pull request was exported from Phabricator. Differential Revision: D75997936 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 9, 2025
Summary: Pull Request resolved: pytorch#11497 Right now we run the ir verifier with a hardcoded set of whitelisted ops. This diff modifies the API to pass the user-defined ops to extend the exception list. See the attached task for more details. Differential Revision: D75997936
hsharma35
approved these changes
Jun 10, 2025
Summary: Pull Request resolved: pytorch#11497 Right now we run the ir verifier with a hardcoded set of whitelisted ops. This diff modifies the API to pass the user-defined ops to extend the exception list. See the attached task for more details. Reviewed By: hsharma35 Differential Revision: D75997936
|
This pull request was exported from Phabricator. Differential Revision: D75997936 |
eigen-k
force-pushed
the
export-D75997936
branch
from
783f981 to
1b812c3
Compare
eigen-k
added
topic: not user facing
release notes: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Right now we run the ir verifier with a hardcoded set of whitelisted ops. This diff modifies the API to pass the user-defined ops to extend the exception list. See the attached task for more details.
Differential Revision: D75997936