Skip to content

Arm backend: Add missing ops to annotator #11517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Jun 10, 2025

  • Adds missing operators to annotator. These are needed to improve numerical precision for llama and deit_tiny.
  • Extends 5D support to runtime by permuting input/output to/from channels_last.
  • Adds unit tests for operators with 5D tensors.

cc @digantdesai @freddan80 @per @zingo

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I1b506c9f5ce7c15cb2e36b2dab31e547513e17fb
Copy link

pytorch-bot bot commented Jun 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11517

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1134b5f with merge base 18e9149 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Jun 10, 2025
@zingo
Copy link
Collaborator

zingo commented Jun 10, 2025

Test fails in test-arm-cortex-m-size-test seem unrelated and seem to happen after this got merged:
#11499

@zingo zingo merged commit 5e555d5 into pytorch:main Jun 10, 2025
193 of 195 checks passed
@zingo
Copy link
Collaborator

zingo commented Jun 10, 2025

Test fails in test-arm-cortex-m-size-test seem unrelated and seem to happen after this got merged: #11499

Well it was another error and not the same, sorry, we are looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants