[ET-VK][ez] Allow Vulkan operator tests to run on devserver and Mac #11648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context #11547 was landed recently which restricted vulkan operator tests to the `ANDROID` platform. Simply update to use the utility function `get_platforms()` so that the tests can run everywhere the vulkan delegate can be built. Differential Revision: [D76620647](https://our.internmc.facebook.com/intern/diff/D76620647/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 13, 2025
## Context #11547 was landed recently which restricted vulkan operator tests to the `ANDROID` platform. Simply update to use the utility function `get_platforms()` so that the tests can run everywhere the vulkan delegate can be built. Differential Revision: [D76620647](https://our.internmc.facebook.com/intern/diff/D76620647/) ghstack-source-id: 290326556 Pull Request resolved: #11648
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11648
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 135fe70 with merge base d660bde ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76620647 |
This PR needs a
|
trivedivivek
approved these changes
Jun 13, 2025
…r and Mac" ## Context #11547 was landed recently which restricted vulkan operator tests to the `ANDROID` platform. Simply update to use the utility function `get_platforms()` so that the tests can run everywhere the vulkan delegate can be built. Differential Revision: [D76620647](https://our.internmc.facebook.com/intern/diff/D76620647/) cc manuelcandales cbilgin [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 13, 2025
Pull Request resolved: #11648 ## Context #11547 was landed recently which restricted vulkan operator tests to the `ANDROID` platform. Simply update to use the utility function `get_platforms()` so that the tests can run everywhere the vulkan delegate can be built. ghstack-source-id: 290331159 @exported-using-ghexport Differential Revision: [D76620647](https://our.internmc.facebook.com/intern/diff/D76620647/)
|
This pull request was exported from Phabricator. Differential Revision: D76620647 |
facebook-github-bot
merged commit b53e0d3
into
gh/SS-JIA/243/base
96 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
JacobSzwejbka
pushed a commit
that referenced
this pull request
Jun 13, 2025
…11652) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11648 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/243/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/243/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/243/orig @diff-train-skip-merge cc @SS-JIA @manuelcandales @cbilgin Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
#11547 was landed recently which restricted vulkan operator tests to the
ANDROIDplatform.Simply update to use the utility function
get_platforms()so that the tests can run everywhere the vulkan delegate can be built.Differential Revision: D76620647
cc @manuelcandales @cbilgin