Skip to content

Use MAP_SHARED to allow sharing memory between processing #11733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

shoumikhin
Copy link
Contributor

No description provided.

@shoumikhin shoumikhin added the release notes: none Do not include this in the release notes label Jun 16, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2025
Copy link

pytorch-bot bot commented Jun 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11733

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 44 Pending, 1 Unrelated Failure

As of commit 8c89e8f with merge base 7565342 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like safe enough.

  • It is using PROT_READ in ::mmap()
  • It is using open(file_name, O_RDONLY);

@shoumikhin shoumikhin merged commit 5ca9876 into main Jun 18, 2025
192 of 193 checks passed
@shoumikhin shoumikhin deleted the shoumikhin-patch-2 branch June 18, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants