Skip to content

Static attention Python I/O manager #11763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Static attention Python I/O manager #11763

merged 1 commit into from
Jun 19, 2025

Conversation

sxu
Copy link
Contributor

@sxu sxu commented Jun 17, 2025

Summary:
Add a helper class to simplify cache and mask management. Useful to modeling for quantization and evaluation.

Also will be used to implement lookahead decoding.

Differential Revision: D76844656

@sxu sxu requested review from lucylq and jackzhxng as code owners June 17, 2025 20:35
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11763

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit 3953a8f with merge base 6b47a16 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76844656

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@sxu sxu requested review from billmguo and YIWENX14 June 17, 2025 20:38
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76844656

@sxu sxu force-pushed the export-D76844656 branch from a477208 to 2fd273d Compare June 17, 2025 21:13
sxu added a commit to sxu/executorch that referenced this pull request Jun 17, 2025
@sxu @facebook-github-bot
Static attention Python I/O manager (pytorch#11763)
2fd273d 
Summary:
Pull Request resolved: pytorch#11763

Add a helper class to simplify cache and mask management. Useful to modeling for quantization and evaluation.

Also will be used to implement lookahead decoding.

Differential Revision: D76844656
YIWENX14
YIWENX14 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@YIWENX14 YIWENX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76844656

@sxu sxu force-pushed the export-D76844656 branch from 2fd273d to 812c645 Compare June 18, 2025 17:15
sxu added a commit to sxu/executorch that referenced this pull request Jun 18, 2025
@sxu @facebook-github-bot
Static attention Python I/O manager (pytorch#11763)
812c645 
Summary:
Pull Request resolved: pytorch#11763

Add a helper class to simplify cache and mask management. Useful to modeling for quantization and evaluation.

Also will be used to implement lookahead decoding.

Differential Revision: D76844656
@sxu @facebook-github-bot
Static attention Python I/O manager (pytorch#11763)
3953a8f 
Summary:
Pull Request resolved: pytorch#11763

Add a helper class to simplify cache and mask management. Useful to modeling for quantization and evaluation.

Also will be used to implement lookahead decoding.

Differential Revision: D76844656
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76844656

@sxu sxu force-pushed the export-D76844656 branch from 812c645 to 3953a8f Compare June 18, 2025 18:09
@facebook-github-bot facebook-github-bot merged commit 137163f into pytorch:main Jun 19, 2025
97 of 104 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@sxu @hinriksnaer
Static attention Python I/O manager
680950c 
Differential Revision: D76844656

Pull Request resolved: pytorch#11763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YIWENX14 YIWENX14 YIWENX14 approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@billmguo billmguo Awaiting requested review from billmguo

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxu @facebook-github-bot @YIWENX14