Skip to content

Arm backend: Prevent illegal fusion in FuseEqualPlaceholdersPass #11781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Jun 18, 2025

  • Constant placeholders with same values but different data types, such as int32 and fp32, shouldn't be fused into a single placeholder. Otherwise, some operators will have operands with mismatched dtypes.
  • Fix the bug by adding a dtype check to fuse only constants with matching types and same values.

Change-Id: Ia4668964f09010ac9416fc8c109549b7e989f724

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Constant placeholders with same values but different data types,
  such as int32 and fp32, shouldn't be fused into a single placeholder.
  Otherwise, some operators will have operands with mismatched dtypes.
- Fix the bug by adding a dtype check to fuse only constants with
  matching types and same values.

Change-Id: Ia4668964f09010ac9416fc8c109549b7e989f724
Signed-off-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jun 18, 2025
Copy link

pytorch-bot bot commented Jun 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11781

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit ce0ba95 with merge base 44d2643 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2025
@YufengShi-dudu YufengShi-dudu removed release notes: arm Changes to the ARM backend delegate labels Jun 18, 2025
@YufengShi-dudu YufengShi-dudu requested a review from zingo June 18, 2025 09:57
@zingo zingo merged commit 7565342 into pytorch:main Jun 18, 2025
192 of 196 checks passed
@YufengShi-dudu YufengShi-dudu added the release notes: arm Changes to the ARM backend delegate label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants