[ET-VK][codegen][fix] Split codegen and SPIR-V compilation into separate steps in gen_vulkan_spv #11823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate steps in gen_vulkan_spv ## Changes * As title * Also removed caching mechanism for the codegen step for simplicity, and ad hoc latency testing didn't reveal any improvements from caching this step ## Motivation As written, gen_vulkan_spv has a potential bug where generated header files are out of date when SPIR-V compilation occurs. Due to the parallelization of SPIR-V compilation, it's possible for a generated GLSL file to be processed before header files that it uses are generated. The fix is to separate the steps of code generation and SPIR-V compilation, such that code generation finished before SPIR-V compilation occurs. Differential Revision: [D77034022](https://our.internmc.facebook.com/intern/diff/D77034022/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 20, 2025
…ate steps in gen_vulkan_spv ## Changes * As title * Also removed caching mechanism for the codegen step for simplicity, and ad hoc latency testing didn't reveal any improvements from caching this step ## Motivation As written, gen_vulkan_spv has a potential bug where generated header files are out of date when SPIR-V compilation occurs. Due to the parallelization of SPIR-V compilation, it's possible for a generated GLSL file to be processed before header files that it uses are generated. The fix is to separate the steps of code generation and SPIR-V compilation, such that code generation finished before SPIR-V compilation occurs. Differential Revision: [D77034022](https://our.internmc.facebook.com/intern/diff/D77034022/) ghstack-source-id: 291681597 Pull Request resolved: #11823
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11823
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cc52ea1 with merge base 496cb05 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77034022 |
This PR needs a
|
manuelcandales
approved these changes
Jun 20, 2025
facebook-github-bot
merged commit 6d569c2
into
gh/SS-JIA/244/base
98 of 101 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
added a commit
that referenced
this pull request
Jun 20, 2025
…ate steps in gen_vulkan_spv (#11829) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11823 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/244/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/244/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/244/orig @diff-train-skip-merge cc @SS-JIA @manuelcandales @cbilgin Co-authored-by: Stephen Jia <[email protected]>
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
…ate steps in gen_vulkan_spv (pytorch#11829) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11823 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/244/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/244/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/244/orig @diff-train-skip-merge cc @SS-JIA @manuelcandales @cbilgin Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Changes
Motivation
As written, gen_vulkan_spv has a potential bug where generated header files are out of date when SPIR-V compilation occurs. Due to the parallelization of SPIR-V compilation, it's possible for a generated GLSL file to be processed before header files that it uses are generated.
The fix is to separate the steps of code generation and SPIR-V compilation, such that code generation finished before SPIR-V compilation occurs.
Differential Revision: D77034022
cc @manuelcandales @cbilgin