-
Notifications
You must be signed in to change notification settings - Fork 608
Reapply "Implement unary_ufunc functions using elementwise_util (#9386)" #11943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/swolchok/474/base
Are you sure you want to change the base?
Conversation
This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11943
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fa745c3 with merge base 91c9ffa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/) ghstack-source-id: 292469056 Pull Request resolved: #11943
This pull request was exported from Phabricator. Differential Revision: D76754824 |
This PR needs a
|
…wise_util (#9386)"" This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/) [ghstack-poisoned]
Pull Request resolved: #11943 This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). ghstack-source-id: 292614913 @exported-using-ghexport Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/)
This pull request was exported from Phabricator. Differential Revision: D76754824 |
noting that this one had green tests except for lintrunner prior to last update |
Stack from ghstack (oldest at bottom):
This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure).
Original summary:
One less set of independent implementations to worry about going forward
(e.g., we don't have to vectorize these separately from elementwise_util
and they get all benefits of elementwise_util).
Differential Revision: D76754824