Skip to content

Reapply "Implement unary_ufunc functions using elementwise_util (#9386)" #11943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh/swolchok/474/base
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jun 24, 2025

Stack from ghstack (oldest at bottom):

This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure).

Original summary:
One less set of independent implementations to worry about going forward
(e.g., we don't have to vectorize these separately from elementwise_util
and they get all benefits of elementwise_util).

Differential Revision: D76754824

This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure).

Original summary:
One less set of independent implementations to worry about going forward
(e.g., we don't have to vectorize these separately from elementwise_util
and they get all benefits of elementwise_util).

Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11943

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fa745c3 with merge base 91c9ffa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jun 24, 2025
This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure).

Original summary:
One less set of independent implementations to worry about going forward
(e.g., we don't have to vectorize these separately from elementwise_util
and they get all benefits of elementwise_util).

Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/)

ghstack-source-id: 292469056
Pull Request resolved: #11943
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76754824

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…wise_util (#9386)""

This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure).

Original summary:
One less set of independent implementations to worry about going forward
(e.g., we don't have to vectorize these separately from elementwise_util
and they get all benefits of elementwise_util).

Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 25, 2025
Pull Request resolved: #11943

This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure).

Original summary:
One less set of independent implementations to worry about going forward
(e.g., we don't have to vectorize these separately from elementwise_util
and they get all benefits of elementwise_util).
ghstack-source-id: 292614913
@exported-using-ghexport

Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76754824

@swolchok
Copy link
Contributor Author

noting that this one had green tests except for lintrunner prior to last update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants