Detect release builds by comparing CMAKE_BUILD_TYPE to Debug, not Release #12045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12045
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit bf512fe with merge base 8bc99d3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jun 27, 2025
mergennachin
approved these changes
Jun 27, 2025
|
noting CI is green before starting stack land |
swolchok
added a commit
that referenced
this pull request
Jun 28, 2025
By accidentally fixing the code in test/build_size_test.sh to correctly detect release builds (EQUAL is for numbers; you need STREQUAL for strings), #12045 broke that script on Mac because `--gc-sections` is not a valid linker flag there. This PR creates a general utility function for stripping dead code in linker flags and uses it everywhere we currently set `--gc-sections`. ghstack-source-id: 58a2fd2 ghstack-comment-id: 3014707984 Pull-Request-resolved: #12089
mergennachin
pushed a commit
that referenced
this pull request
Jun 28, 2025
By accidentally fixing the code in test/build_size_test.sh to correctly detect release builds (EQUAL is for numbers; you need STREQUAL for strings), #12045 broke that script on Mac because `--gc-sections` is not a valid linker flag there. This PR creates a general utility function for stripping dead code in linker flags and uses it everywhere we currently set `--gc-sections`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinSizeRel and RelWithDebInfo are also release builds.