Skip to content

Arm backend: Add acosh decomposition pass and test #12105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

emmakujala
Copy link
Contributor

@emmakujala emmakujala commented Jun 30, 2025

Decomposes acosh into TOSA-operations.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: Emma Kujala <[email protected]>
Change-Id: If0a9ce302fc5c4fc2decb95a28f64c8163a88518
@emmakujala emmakujala requested a review from digantdesai as a code owner June 30, 2025 06:50
Copy link

pytorch-bot bot commented Jun 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12105

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 44519f2 with merge base bf9cd34 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2025
@emmakujala
Copy link
Contributor Author

@pytorchbot label "ciflow/trunk"

Copy link

pytorch-bot bot commented Jun 30, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@emmakujala
Copy link
Contributor Author

@pytorchbot label "partner:arm"

Copy link

pytorch-bot bot commented Jun 30, 2025

Didn't find following labels among repository labels: partner:arm

@emmakujala
Copy link
Contributor Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 30, 2025
@emmakujala
Copy link
Contributor Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot bot added the release notes: arm Changes to the ARM backend delegate label Jun 30, 2025
@emmakujala
Copy link
Contributor Author

@pytorchbot label "ciflow/trunk"

Copy link

pytorch-bot bot commented Jun 30, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@emmakujala
Copy link
Contributor Author

@pytorchbot label ciflow/trunk

Copy link

pytorch-bot bot commented Jun 30, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@emmakujala
Copy link
Contributor Author

@pytorchbot label "ciflow/trunk"

Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@oscarandersson8218 oscarandersson8218 merged commit f0a7d10 into pytorch:main Jun 30, 2025
197 of 199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants