Skip to content

Arm backend: Add U55 operator check for View #12106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

Sebastian-Larsson
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented Jun 30, 2025

In order for the view operator to be compatible with the channels-last format of TosaBackend, transposes may need to be inserted before and after the view op. The transose operator comes with some constraints on U55. One such constraint is that the product of the axes should not exceed 65536. With this patch a check if implemented for the view operator to prevent such operators from being delegated.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

In order for the view operator to be compatible with the channels-last
format of TosaBackend, transposes may need to be inserted before and
after the view op. The transose operator comes with some constraints on
U55. One such constraint is that the product of the axes should not
exceed 65536. With this patch a check if implemented for the view
operator to prevent such operators from being delegated.

Change-Id: Ic6259899fecc157452bed48ea82096089e125789
Signed-off-by: Sebastian Larsson <[email protected]>
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jun 30, 2025
Copy link

pytorch-bot bot commented Jun 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12106

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit aeacfa5 with merge base bf9cd34 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2025
@zingo
Copy link
Collaborator

zingo commented Jun 30, 2025

coreml fails unrelated

@zingo zingo merged commit 5d2193f into pytorch:main Jun 30, 2025
195 of 196 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants