Fix xnnpack demo #122
Closed
Fix xnnpack demo #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48661299 |
Summary: Pull Request resolved: pytorch/executorch#122 Fixed several issues with the XNNPACK demo: - broken buck build in OSS (see errors in P813564245) - `buck2 build //examples/backend:xnn_executor_runner` doesn't build - `buck2 build //examples/backend:xnnpack_examples` doesn't build - broken `README` file, e.g. missing `.md` so no format at all ([see the file in OSS](https://github.com/pytorch/executorch/blob/main/examples/backend/README)) - broken generated file names, e.g. ugly name like `mv2_xnnpack_.pte` or `mv2_xnnpack__quantize.pte` Reviewed By: kirklandsign Differential Revision: D48661299 fbshipit-source-id: e670b52cf5fb7636810a3fc4e5b0d52665d4931e
|
This pull request was exported from Phabricator. Differential Revision: D48661299 |
guangy10
force-pushed
the
export-D48661299
branch
from
cc511aa to
24ca362
Compare
|
This pull request has been merged in 35db16d. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
Summary: TSIA. After #122, we can now add XNNPACK tests to CI. Note that `xnn_executor_runner` is only available via buck2 here, its cmake support will come in the next PR. Pull Request resolved: #123 Test Plan: Spot check for `add` example which supports both XNNPACK and quantization. Both are tested: Linux: https://github.com/pytorch/executorch/actions/runs/5970562477/job/16198874573?pr=123 MacOS: https://github.com/pytorch/executorch/actions/runs/5970562477/job/16198877840?pr=123 Reviewed By: guangy10, kirklandsign Differential Revision: D48670404 Pulled By: huydhn fbshipit-source-id: 51974887cce141d9abccf3581f5003dfb23fe53d
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
May 14, 2025
Merge in AITEC/executorch from feature/nxf93343/add-arguments-to-graph-vizualizer to main-nxp * commit 'd7f00fe0d22415070dfdad20f4bd1538ad921281': Fix de/quantize nodes visualization Add option to visualize directly fx.Graph in dot exporter Add option to show arguments in dot representation of graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed several issues with the XNNPACK demo:
buck2 build //examples/backend:xnn_executor_runnerdoesn't build in OSSbuck2 build //examples/backend:xnnpack_examplesdoesn't build Meta-internallyREADMEfile, e.g. missing.mdso no format at allmv2_xnnpack_.pteDifferential Revision: D48661299