Skip to content

Use Module facade. #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Use Module facade. #1496

wants to merge 3 commits into from

Conversation

shoumikhin
Copy link
Contributor

Summary: .

Differential Revision: D52440991

Copy link

pytorch-bot bot commented Dec 28, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1496

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 73c095b with merge base 53b99f3 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 28, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52440991

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52440991

Summary:

Some comments, simplifications and efficiency improvements.

Differential Revision: D52440671
Summary:

.

Differential Revision: D52440934
Summary:

.

Differential Revision: D52440991
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52440991

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0d120ba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants