Decentralize portable lib cmake build file #150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Split out `portable_kernels_bindings` library build code from root `CMakeLists.txt` to `kernels/portable/CMakeLists.txt`. This makes the root `CMakeLists.txt` a bit simpler. Also making the linker options a bit more portable. Differential Revision: D48712541 fbshipit-source-id: 5bb991568cf330d531c8c6585cf6b69f1464e391
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48712541 |
|
This pull request has been merged in cca86d0. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
…ack (#150) * new gguf parsing for Q40 that conforms with pytorch's quantization stack * updates * add q6_k and clean up q40 * fixes to unpack_q40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Split out
portable_kernels_bindingslibrary build code from rootCMakeLists.txttokernels/portable/CMakeLists.txt. This makes the rootCMakeLists.txta bit simpler.Also making the linker options a bit more portable.
Differential Revision: D48712541