[MPS] Build MPS delegate with Werror=1 #1736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1736
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a5c8e7e with merge base 1ebd43e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Please rebase to resolve conflicts |
Cast to FP16 only if initial placeholder is FP32
DenisVieriu97
force-pushed
the
denis/fix_warnings
branch
from
065909f to
a5c8e7e
Compare
|
Thank you @shoumikhin. |
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shoumikhin merged this pull request in 52ea3c6. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Jan 29, 2024
Summary: Summary of changes: - Build MPS Delegate with Werror=1 by default (tested on macOS12.0, 13.0 and 14.0) - Cast the placeholders to FP16 only if initial placeholder is FP32. Other data types remain unchanged. cc shoumikhin, cccclai, larryliu0820 Pull Request resolved: pytorch#1736 Reviewed By: cccclai Differential Revision: D53150094 Pulled By: shoumikhin fbshipit-source-id: f8f3b4d74ffbf06cfc97a20a115eefd0a44b7ef3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
cc @shoumikhin, @cccclai, @larryliu0820