Skip to content

Add support for const inputs in runner_util #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

tarun292
Copy link
Contributor

@tarun292 tarun292 commented Feb 2, 2024

Summary: These are all valid input types now in an Executorch program.

Differential Revision: D53335087

Copy link

pytorch-bot bot commented Feb 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1810

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit bb5e19d with merge base 75aa0b4 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53335087

tarun292 added a commit that referenced this pull request Feb 15, 2024
Summary:

These are all valid input types now in an Executorch program.

Differential Revision: D53335087
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53335087

tarun292 added a commit that referenced this pull request Feb 15, 2024
Summary:

These are all valid input types now in an Executorch program.

Differential Revision: D53335087
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53335087

Summary:

For Seamless model we ran into a case where we have to either return an int/float or a list of int's/float's from the model. We need to add support for this in the emitter and make sure that the memory planning pass ignores these.

Reviewed By: angelayi

Differential Revision: D53256808
Summary:

These are all valid input types now in an Executorch program.

Differential Revision: D53335087
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53335087

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in bfdd8ab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants