Skip to content

Upgrade buck2 toolchain #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Upgrade buck2 toolchain #1996

wants to merge 3 commits into from

Conversation

bigfootjon
Copy link
Member

@bigfootjon bigfootjon commented Feb 15, 2024

This bumps the toolchain to the latest versions so I can unify the shim: #1993

Test plan:

CI on the PR passes

Copy link

pytorch-bot bot commented Feb 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1996

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3f64590 with merge base 1689ed8 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 15, 2024
@huydhn
Copy link
Contributor

huydhn commented Feb 16, 2024

For the context, MacOS has the logic https://github.com/pytorch/executorch/blob/main/.ci/scripts/setup-macos.sh#L30-L33 to not download buck every time the job runs by checking if buck binary exists. The fault here is that it doesn't check for the buck version. We could fix this by checking for buck version and if it doesn't match the pinned version, then installing the new version

@facebook-github-bot
Copy link
Contributor

@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bigfootjon merged this pull request in f4c4ad3.

@bigfootjon bigfootjon deleted the buck2-toolchain-bump branch February 20, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants