Clarify log when ignoring mlock error #2004
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It's been confusing to users when they see an Error-level log complaining about an `mlock()` failure even though it's being ignored. We do print a follow-up Info line after it, but some users may disable Info messages. Instead, print the message at Info level when ignoring it, and make it clear that it is being ignored. While I'm here, print the file offset of the region that we're trying to lock, to make it easier to figure out which segment is failing to lock. Differential Revision: D53876334
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2004
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 55f0fad with merge base 7b1ac5d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53876334 |
|
This pull request has been merged in 288c948. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It's been confusing to users when they see an Error-level log complaining about an
mlock()failure even though it's being ignored. We do print a follow-up Info line after it, but some users may disable Info messages.Instead, print the message at Info level when ignoring it, and make it clear that it is being ignored.
While I'm here, print the file offset of the region that we're trying to lock, to make it easier to figure out which segment is failing to lock.
Differential Revision: D53876334