Skip to content

[llm] Add CMake for llama runner #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Feb 21, 2024

Stack from ghstack (oldest at bottom):

Summary: As titled. Also add a CI job. Will run a model in next PR.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D53996450

Summary: As titled. Also add a CI job. Will run a model in next PR.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2022

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7023d86 with merge base 0fa67f6 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

larryliu0820 added a commit that referenced this pull request Feb 21, 2024
Summary: As titled. Also add a CI job. Will run a model in next PR.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e1e7778
Pull Request resolved: #2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2024
Summary: As titled. Also add a CI job. Will run a model in next PR.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Feb 21, 2024
Summary: As titled. Also add a CI job. Will run a model in next PR.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: d4b156f
Pull Request resolved: #2022
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6b1fc8b.

facebook-github-bot pushed a commit that referenced this pull request Feb 22, 2024
Summary:
Building the demo apps on iOS is broken after #2022 because it switches the `extension_module` library from a static to a shared one.  AFAIK, the latter requires code signing and it's failing on CI with the following error `Signing for "extension_module" requires a development team`

I'm not quite sure what would be the best way to address this, but keeping the library as a static one for iOS build seems like an easy workaround.

Pull Request resolved: #2038

Reviewed By: larryliu0820

Differential Revision: D54047521

Pulled By: huydhn

fbshipit-source-id: e752f29bb1fefd355525a40d586f89659119a625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants