-
Notifications
You must be signed in to change notification settings - Fork 608
Build static extension_module lib for iOS demo apps #2038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2038
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b5364cc with merge base 8fed60b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hmm, the failure is now fixed, but one test fails Updated: The failure looks flaky as all tests pass locally for me with the same setup. |
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Building the demo apps on iOS is broken after #2022 because it switches the
extension_module
library from a static to a shared one. AFAIK, the latter requires code signing and it's failing on CI with the following errorSigning for "extension_module" requires a development team
I'm not quite sure what would be the best way to address this, but keeping the library as a static one for iOS build seems like an easy workaround.