Skip to content

Build static extension_module lib for iOS demo apps #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Feb 22, 2024

Building the demo apps on iOS is broken after #2022 because it switches the extension_module library from a static to a shared one. AFAIK, the latter requires code signing and it's failing on CI with the following error Signing for "extension_module" requires a development team

I'm not quite sure what would be the best way to address this, but keeping the library as a static one for iOS build seems like an easy workaround.

Copy link

pytorch-bot bot commented Feb 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2038

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b5364cc with merge base 8fed60b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2024
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn
Copy link
Contributor Author

huydhn commented Feb 22, 2024

Hmm, the failure is now fixed, but one test fails MobileNetClassifierTest.testV3WithCoreMLBackend(), let me do a rebase

Updated: The failure looks flaky as all tests pass locally for me with the same setup.

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 4853727.

@huydhn huydhn deleted the build-static-extension-module-ios branch August 13, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants