[ET-VK][ez] Introduce GraphBuilder abstraction #2061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context This changeset introduces `VkGraphBuilder` to handle parsing an `ExportedProgram` and parsing it to construct a `VkGraph` for serialization. Most of the graph parsing functionality previously implemented in `vulkan_preprocess` is now in `VkGraphBuilder`. The main motivation of this refactor is to simplify `vulkan_preprocess`. Differential Revision: [D54128091](https://our.internmc.facebook.com/intern/diff/D54128091/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2061
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 47e1b1d with merge base 33ba563 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54128091 |
## Context This changeset introduces `VkGraphBuilder` to handle parsing an `ExportedProgram` and parsing it to construct a `VkGraph` for serialization. Most of the graph parsing functionality previously implemented in `vulkan_preprocess` is now in `VkGraphBuilder`. The main motivation of this refactor is to simplify `vulkan_preprocess`. Differential Revision: [D54128091](https://our.internmc.facebook.com/intern/diff/D54128091/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54128091 |
manuelcandales
approved these changes
Feb 23, 2024
|
This pull request has been merged in a58bfd0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
This changeset introduces
VkGraphBuilderto handle parsing anExportedProgramand parsing it to construct aVkGraphfor serialization. Most of the graph parsing functionality previously implemented invulkan_preprocessis now inVkGraphBuilder.The main motivation of this refactor is to simplify
vulkan_preprocess.Differential Revision: D54128091