-
Notifications
You must be signed in to change notification settings - Fork 607
Move graph runtime from PT directory to ET directory #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2086
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a516e64 with merge base 3e806ff ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D54133350 |
manuelcandales
approved these changes
Feb 23, 2024
c6896d9
to
3e1cd73
Compare
Summary: ## Context Move Vulkan graph runtime from PyTorch directory to ExecuTorch directory to improve development logistics: * ExecuTorch delegate changes will no longer require export to PyTorch directory * Makes it much easier to enable OSS build for Vulkan delegate Reviewed By: shoumikhin Differential Revision: D54133350
3e1cd73
to
a516e64
Compare
@pytorchbot merge -f "Landed Internally" |
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 1, 2024
Summary: ## Context Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository. This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without 1. Having to export changes to PyTorch 2. Having to worry about breaking ATen Vulkan The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch. Differential Revision: D55607115
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 1, 2024
Summary: Pull Request resolved: pytorch#2797 ## Context Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository. This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without 1. Having to export changes to PyTorch 2. Having to worry about breaking ATen Vulkan The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch. Reviewed By: copyrightly Differential Revision: D55607115
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 1, 2024
Summary: Pull Request resolved: pytorch#2797 ## Context Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository. This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without 1. Having to export changes to PyTorch 2. Having to worry about breaking ATen Vulkan The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch. Reviewed By: copyrightly Differential Revision: D55607115
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 1, 2024
Summary: Pull Request resolved: pytorch#2797 ## Context Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository. This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without 1. Having to export changes to PyTorch 2. Having to worry about breaking ATen Vulkan The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch. Reviewed By: copyrightly Differential Revision: D55607115
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: pytorch#2797 ## Context Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository. This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without 1. Having to export changes to PyTorch 2. Having to worry about breaking ATen Vulkan The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch. bypass-github-export-checks Reviewed By: copyrightly Differential Revision: D55607115
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: pytorch#2797 ## Context Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository. This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without 1. Having to export changes to PyTorch 2. Having to worry about breaking ATen Vulkan The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch. bypass-github-export-checks Reviewed By: copyrightly Differential Revision: D55607115
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: pytorch#2797 ## Context Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository. This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without 1. Having to export changes to PyTorch 2. Having to worry about breaking ATen Vulkan The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch. bypass-github-export-checks Reviewed By: copyrightly Differential Revision: D55607115
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: #2797 ## Context Similar to #2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository. This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without 1. Having to export changes to PyTorch 2. Having to worry about breaking ATen Vulkan The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch. bypass-github-export-checks Reviewed By: copyrightly Differential Revision: D55607115 fbshipit-source-id: a410d345be515dd05bb3068c17555d12556b3648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Move Vulkan graph runtime from PyTorch directory to ExecuTorch directory to improve development logistics:
Differential Revision: D54133350