Skip to content

Move graph runtime from PT directory to ET directory #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Feb 23, 2024

Summary:

Context

Move Vulkan graph runtime from PyTorch directory to ExecuTorch directory to improve development logistics:

  • ExecuTorch delegate changes will no longer require export to PyTorch directory
  • Makes it much easier to enable OSS build for Vulkan delegate

Differential Revision: D54133350

Copy link

pytorch-bot bot commented Feb 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2086

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a516e64 with merge base 3e806ff (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54133350

@SS-JIA SS-JIA force-pushed the export-D54133350 branch 4 times, most recently from c6896d9 to 3e1cd73 Compare February 24, 2024 07:25
Summary:
## Context

Move Vulkan graph runtime from PyTorch directory to ExecuTorch directory to improve development logistics:

* ExecuTorch delegate changes will no longer require export to PyTorch directory
* Makes it much easier to enable OSS build for Vulkan delegate

Reviewed By: shoumikhin

Differential Revision: D54133350
@SS-JIA
Copy link
Contributor Author

SS-JIA commented Feb 24, 2024

@pytorchbot merge -f "Landed Internally"

@SS-JIA SS-JIA closed this Feb 24, 2024
SS-JIA added a commit to SS-JIA/executorch-1 that referenced this pull request Apr 1, 2024
Summary:
## Context

Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository.

This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without

1. Having to export changes to PyTorch
2. Having to worry about breaking ATen Vulkan

The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch.

Differential Revision: D55607115
SS-JIA added a commit to SS-JIA/executorch-1 that referenced this pull request Apr 1, 2024
Summary:
Pull Request resolved: pytorch#2797

## Context

Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository.

This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without

1. Having to export changes to PyTorch
2. Having to worry about breaking ATen Vulkan

The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch.

Reviewed By: copyrightly

Differential Revision: D55607115
SS-JIA added a commit to SS-JIA/executorch-1 that referenced this pull request Apr 1, 2024
Summary:
Pull Request resolved: pytorch#2797

## Context

Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository.

This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without

1. Having to export changes to PyTorch
2. Having to worry about breaking ATen Vulkan

The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch.

Reviewed By: copyrightly

Differential Revision: D55607115
SS-JIA added a commit to SS-JIA/executorch-1 that referenced this pull request Apr 1, 2024
Summary:
Pull Request resolved: pytorch#2797

## Context

Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository.

This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without

1. Having to export changes to PyTorch
2. Having to worry about breaking ATen Vulkan

The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch.

Reviewed By: copyrightly

Differential Revision: D55607115
SS-JIA added a commit to SS-JIA/executorch-1 that referenced this pull request Apr 2, 2024
Summary:
Pull Request resolved: pytorch#2797

## Context

Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository.

This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without

1. Having to export changes to PyTorch
2. Having to worry about breaking ATen Vulkan

The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch.

bypass-github-export-checks

Reviewed By: copyrightly

Differential Revision: D55607115
SS-JIA added a commit to SS-JIA/executorch-1 that referenced this pull request Apr 2, 2024
Summary:
Pull Request resolved: pytorch#2797

## Context

Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository.

This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without

1. Having to export changes to PyTorch
2. Having to worry about breaking ATen Vulkan

The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch.

bypass-github-export-checks

Reviewed By: copyrightly

Differential Revision: D55607115
SS-JIA added a commit to SS-JIA/executorch-1 that referenced this pull request Apr 2, 2024
Summary:
Pull Request resolved: pytorch#2797

## Context

Similar to pytorch#2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository.

This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without

1. Having to export changes to PyTorch
2. Having to worry about breaking ATen Vulkan

The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch.

bypass-github-export-checks

Reviewed By: copyrightly

Differential Revision: D55607115
facebook-github-bot pushed a commit that referenced this pull request Apr 2, 2024
Summary:
Pull Request resolved: #2797

## Context

Similar to #2086 which moved the `ComputeGraph` API to the ExecuTorch repo, this changeset forks the Vulkan Compute API (under `pytorch/aten/src/ATen/native/vulkan/api`) to the ExecuTorch repository.

This is critical for development speed as it allows us to make foundational changes to the Vulkan compute API without

1. Having to export changes to PyTorch
2. Having to worry about breaking ATen Vulkan

The next change in the stack will deprecate the `at::native::vulkan` namespace now that everything is local to ExecuTorch.

bypass-github-export-checks

Reviewed By: copyrightly

Differential Revision: D55607115

fbshipit-source-id: a410d345be515dd05bb3068c17555d12556b3648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants