[ET-VK] Separate OpNode to PrepackNode/ExecuteNode #2102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derived classes of `OpNode` are currently used only for prepack or execute, never both. This means they need not have both API. Inspired by [Stephen's comment](https://www.internalfb.com/diff/D53982441?dst_version_fbid=370105355800543&transaction_fbid=940226924354801), we will build on `ExecuteNode` to be initialized with member functions for `create_params_block()`, `get_shader()`, etc. `PrepackNode` doesn't need these members. Hence, it makes sense to separate the classes. Feel free to suggest better names. I don't really like mine. Differential Revision: [D54042646](https://our.internmc.facebook.com/intern/diff/D54042646/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2102
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2438854 with merge base 1d74652 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54042646 |
jorgep31415
added a commit
that referenced
this pull request
Feb 26, 2024
Derived classes of `OpNode` are currently used only for prepack or execute, never both. This means they need not have both API. Inspired by [Stephen's comment](https://www.internalfb.com/diff/D53982441?dst_version_fbid=370105355800543&transaction_fbid=940226924354801), we will build on `ExecuteNode` to be initialized with member functions for `create_params_block()`, `get_shader()`, etc. `PrepackNode` doesn't need these members. Hence, it makes sense to separate the classes. Feel free to suggest better names. I don't really like mine. Differential Revision: [D54042646](https://our.internmc.facebook.com/intern/diff/D54042646/) ghstack-source-id: 216481872 Pull Request resolved: #2102
SS-JIA
approved these changes
Feb 26, 2024
|
This pull request has been merged in dc5a9af. |
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Derived classes of
OpNodeare currently used only for prepack or execute, never both. This means they need not have both API.Inspired by Stephen's comment, we will build on
ExecuteNodeto be initialized with member functions forcreate_params_block(),get_shader(), etc.PrepackNodedoesn't need these members. Hence, it makes sense to separate the classes.Feel free to suggest better names. I don't really like mine.
Differential Revision: D54042646