[ET-VK][EZ] Split Graph.h classes into multiple files #2150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I always get lost finding the right class within `Graph.h/cpp`, so we split them into - `ComputeGraph.h/cpp` - `ExecuteNode.h` - `PrepackNode.h` - `SharedObject.h/cpp` and move `ValueRef`/`IOValueRef` into `Value.h`. Differential Revision: [D54272392](https://our.internmc.facebook.com/intern/diff/D54272392/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54272392 |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2150
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4832851 with merge base 1d74652 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
approved these changes
Feb 27, 2024
|
This pull request has been merged in 3ed5144. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
I always get lost finding the right class within `Graph.h/cpp`, so we split them into - `ComputeGraph.h/cpp` - `ExecuteNode.h` - `PrepackNode.h` - `SharedObject.h/cpp` and move `ValueRef`/`IOValueRef` into `Value.h`. Differential Revision: [D54272392](https://our.internmc.facebook.com/intern/diff/D54272392/) ghstack-source-id: 216691329 Pull Request resolved: pytorch/executorch#2150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I always get lost finding the right class within
Graph.h/cpp, so we split them intoComputeGraph.h/cppExecuteNode.hPrepackNode.hSharedObject.h/cppand move
ValueRef/IOValueRefintoValue.h.Differential Revision: D54272392