[ET-VK][EZ] Refactor graph directory structure #2151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I always get lost in the current structure, so we 1. introduce `containers/`, `ops/`, and `ops/impl/` to flatten the directory, and 2. fix some include header ordering. ``` [[email protected] /data/users/jorgep31415/fbsource/fbcode/executorch/backends/vulkan/runtime/graph (4f468a807)]$ tree . ├── ComputeGraph.cpp ├── ComputeGraph.h ├── containers │ ├── Constant.cpp │ ├── Constant.h │ ├── SharedObject.cpp │ ├── SharedObject.h │ ├── Types.cpp │ ├── Types.h │ └── Value.h ├── GraphConfig.h └── ops ├── ExecuteNode.h ├── Functions.cpp ├── Functions.h ├── impl │ ├── Arithmetic.cpp │ ├── Arithmetic.h │ ├── Copy.cpp │ ├── Copy.h │ ├── Staging.cpp │ └── Staging.h ├── OperatorRegistry.cpp ├── OperatorRegistry.h └── PrepackNode.h 3 directories, 22 files ``` Differential Revision: [D54272391](https://our.internmc.facebook.com/intern/diff/D54272391/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2151
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 758d6d9 with merge base 1d74652 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jorgep31415
added a commit
that referenced
this pull request
Feb 27, 2024
I always get lost in the current structure, so we
1. introduce `containers/`, `ops/`, and `ops/impl/` to flatten the directory, and
2. fix some include header ordering.
```
[jorgep31415devvm15882.vll0 /data/users/jorgep31415/fbsource/fbcode/executorch/backends/vulkan/runtime/graph (4f468a807)]$ tree
.
├── ComputeGraph.cpp
├── ComputeGraph.h
├── containers
│ ├── Constant.cpp
│ ├── Constant.h
│ ├── SharedObject.cpp
│ ├── SharedObject.h
│ ├── Types.cpp
│ ├── Types.h
│ └── Value.h
├── GraphConfig.h
└── ops
├── ExecuteNode.h
├── Functions.cpp
├── Functions.h
├── impl
│ ├── Arithmetic.cpp
│ ├── Arithmetic.h
│ ├── Copy.cpp
│ ├── Copy.h
│ ├── Staging.cpp
│ └── Staging.h
├── OperatorRegistry.cpp
├── OperatorRegistry.h
└── PrepackNode.h
3 directories, 22 files
```
Differential Revision: [D54272391](https://our.internmc.facebook.com/intern/diff/D54272391/)
ghstack-source-id: 216697508
Pull Request resolved: #2151
|
This pull request was exported from Phabricator. Differential Revision: D54272391 |
SS-JIA
approved these changes
Feb 27, 2024
|
This pull request has been merged in 8aca441. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I always get lost in the current structure, so we
containers/,ops/, andops/impl/to flatten the directory, andDifferential Revision: D54272391