Adding Support for preserve_format when converting Evalues #2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2242
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 84904b7 with merge base 61d6393 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54288165 |
Jack-Khuu
force-pushed
the
export-D54288165
branch
from
6e4f2c0 to
b9370f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54288165 |
Jack-Khuu
force-pushed
the
export-D54288165
branch
from
b9370f2 to
150c8f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54288165 |
Jack-Khuu
force-pushed
the
export-D54288165
branch
from
150c8f7 to
84904b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54288165 |
dbort
approved these changes
Mar 7, 2024
|
This pull request has been merged in 23c8172. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds support for
torch.preserve_formatwhen casting constants to Evalues.Differential Revision: D54288165