Support None's When Calculating Emitted ExecutionPlan Outputs #2243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2243
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit ef9c132 with merge base 6be02ce ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54328663 |
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 5, 2024
…ts (pytorch#2243) Summary: Previously Support for outputting int/float was added in D53256808 for Seamless This extends on this by dropping None Outputs (Which can be outputted by NanoGPT) Differential Revision: D54328663
Jack-Khuu
force-pushed
the
export-D54328663
branch
from
24b7921 to
9994c93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54328663 |
Jack-Khuu
force-pushed
the
export-D54328663
branch
from
9994c93 to
d87291e
Compare
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 5, 2024
…ts (pytorch#2243) Summary: Previously Support for outputting int/float was added in D53256808 for Seamless This extends on this by dropping None Outputs (Which can be outputted by NanoGPT) Differential Revision: D54328663
|
This pull request was exported from Phabricator. Differential Revision: D54328663 |
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 6, 2024
…ts (pytorch#2243) Summary: Previously Support for outputting int/float was added in D53256808 for Seamless This extends on this by dropping None Outputs (Which can be outputted by NanoGPT) Differential Revision: D54328663
Jack-Khuu
force-pushed
the
export-D54328663
branch
from
d87291e to
204759c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54328663 |
…ts (pytorch#2243) Summary: Previously Support for outputting int/float was added in D53256808 for Seamless This extends on this by dropping None Outputs (Which can be outputted by NanoGPT) Reviewed By: JacobSzwejbka Differential Revision: D54328663
Jack-Khuu
force-pushed
the
export-D54328663
branch
from
204759c to
ef9c132
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54328663 |
Jack-Khuu
changed the title
Gasoonjia
approved these changes
Mar 7, 2024
|
This pull request has been merged in b22c224. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously Support for outputting int/float was added in D53256808 for Seamless
This extends on this by dropping None Outputs (Which can be outputted by NanoGPT)
Differential Revision: D54328663