Skip to content

Stop after first EOS post-prompt #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Stop after first EOS post-prompt #2255

wants to merge 1 commit into from

Conversation

mikekgfb
Copy link

@mikekgfb mikekgfb commented Mar 5, 2024

Summary: Stop after first EOS post-prompt

Reviewed By: shoumikhin

Differential Revision: D54525365

Copy link

pytorch-bot bot commented Mar 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2255

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 475b582 with merge base aed32c4 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54525365

facebook-github-bot pushed a commit that referenced this pull request Mar 5, 2024
Summary:

Stop after first EOS post-promptfor FS2

Reviewed By: shoumikhin

Differential Revision: D54525365
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54525365

facebook-github-bot pushed a commit that referenced this pull request Mar 5, 2024
Summary:

Stop after first EOS post-promptfor FS2

Reviewed By: shoumikhin

Differential Revision: D54525365
facebook-github-bot pushed a commit that referenced this pull request Mar 5, 2024
Summary:

Stop after first EOS post-promptfor FS2

Reviewed By: shoumikhin

Differential Revision: D54525365
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54525365

mikekgfb pushed a commit that referenced this pull request Mar 5, 2024
Summary:

Stop after first EOS post-promptfor FS2

Reviewed By: shoumikhin

Differential Revision: D54525365
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54525365

facebook-github-bot pushed a commit that referenced this pull request Mar 5, 2024
Summary:

Stop after first EOS post-promptfor FS2

Reviewed By: shoumikhin

Differential Revision: D54525365
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54525365

mikekgfb pushed a commit that referenced this pull request Mar 5, 2024
Summary:
Pull Request resolved: #2255

Stop after first EOS post-promptfor FS2

Reviewed By: shoumikhin

Differential Revision: D54525365
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54525365

@mikekgfb mikekgfb changed the title Stop after first EOS post-promptfor FS2 Stop after first EOS post-prompt Mar 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54525365

mikekgfb pushed a commit that referenced this pull request Mar 5, 2024
Summary:
Pull Request resolved: #2255

Stop after first EOS post-prompt

Reviewed By: shoumikhin

Differential Revision: D54525365
Summary:

Stop after first EOS post-prompt

Reviewed By: larryliu0820, shoumikhin

Differential Revision: D54525365
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54525365

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 187079e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants