-
Notifications
You must be signed in to change notification settings - Fork 606
Remove runtime dependency on ATen/native/vulkan/impl #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
This pull request was exported from Phabricator. Differential Revision: D54555273 |
Summary: bypass-github-export-checks The only missing logic is copied from ``` ATen/native/vulkan/impl/Common.h/cpp ``` to ``` executorch/backends/vulkan/runtime/graph/ops/OpUtils.h/cpp ``` We can create a utils directory and improve their file organization, in a follow up change. Reviewed By: SS-JIA Differential Revision: D54555273
This pull request was exported from Phabricator. Differential Revision: D54555273 |
5496823
to
47a6922
Compare
This pull request has been merged in bcba739. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/periodic
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
module: vulkan
Issues related to the Vulkan delegate and code under backends/vulkan/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The only missing logic is copied from
to
We can create a utils directory and improve their file organization, in a follow up change.
Differential Revision: D54555273