Skip to content

Regression fixes and tidyup for Arm backend #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Regression fixes and tidyup for Arm backend #2372

wants to merge 8 commits into from

Conversation

robell
Copy link
Collaborator

@robell robell commented Mar 12, 2024

Fixes for a few things:

robell and others added 6 commits March 12, 2024 17:48
@robell
Tidy git status output
5b64ac6 
Signed-off-by: Rob Elliott <[email protected]>
Change-Id: Id21f8aeb2d77a5370c8b7fe76876260ca9203a63
@robell
Add quantisation and external model support to aot_arm_compiler
3b9625a 
Signed-off-by: Rob Elliott <[email protected]>
Change-Id: Ie8cb10d6ec15d818fe4592dd487be25c940aa0c6
@robell
Move Arm builds to C++17 std
886df77 
Signed-off-by: Rob Elliott <[email protected]>
Change-Id: I8a7e227c459b06b6c0a3b273a3c275e6855ec813
@robell
fix for missed regression on save_pte_program coming from pytorch#2307
c28fdee 
Signed-off-by: Rob Elliott <[email protected]>
Change-Id: I584410307d4b9c2635ae6647cd9bd138bf596c45
@robell
move vela pin for mnv2 fixes
fc1ce6f 
Signed-off-by: Rob Elliott <[email protected]>
Change-Id: I5a0270884ef01cc1be1074a7adbcd3d95c2de02d
@robell
Merge branch 'pytorch:main' into buildfix
98d9c40
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2372

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8a417dc with merge base 45df800 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • trunk / test-coreml-delegate / macos-job (gh)
    /Users/runner/work/executorch/executorch/pytorch/executorch/backends/apple/coreml/runtime/sdk/ETCoreMLModelProfiler.mm:228:47: error: unknown type name 'MLModelStructureProgramOperation'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2024
@robell robell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Mar 12, 2024
digantdesai
digantdesai approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, looks great!

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Pull Request cannot be merged
Rebase please?

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

sigh, rebase please? Thanks. Something is wrong. I might have to commandeer it.

@robell
Copy link
Collaborator Author

robell commented Mar 18, 2024

sigh, rebase please? Thanks. Something is wrong. I might have to commandeer it.

sorry was out, done now, hopefully this works.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 252508b.

@robell robell deleted the buildfix branch May 3, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robell @facebook-github-bot @digantdesai