Don't build unnecessary flatbuffs/flatcc targets #2466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2466
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 98736c6 with merge base 1d852ed ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54966722 |
Summary: On some linux systems, the pybindings build would fail with `relocation R_X86_64_32 against '.rodata' can not be used when making a shared object; recompile with -fPIC` Digging into it further, I also noticed that etdump was depending on `libflatcc` (the compiler) instead of `libflatccrt` (the runtime). Fix that dep, then mark `flatccrt` as positition-independent (thus adding `-fPIC` on appropriate systems) to fix the pybindings build. Reviewed By: larryliu0820 Differential Revision: D54966723
Summary: We're currently building unnecessary pieces of the flatbuffers and flatcc submodules. I had tried disabling them before for flatbuffers, but didn't do it the right way. Now do it the right way, saving us some time during the build. Differential Revision: D54966722
|
This pull request was exported from Phabricator. Differential Revision: D54966722 |
larryliu0820
approved these changes
Mar 18, 2024
|
This pull request has been merged in 8b6f5d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're currently building unnecessary pieces of the flatbuffers and flatcc submodules. I had tried disabling them before for flatbuffers, but didn't do it the right way.
Now do it the right way, saving us some time during the build.
Differential Revision: D54966722