Skip to content

use partitioner instance directly in to_backend #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Mar 19, 2024

Summary: to_backend either takes partitioner or a dict of partitioner key: method_name, value: partitioner. We shouldn't do key as the backend name and value as the partitioner.

Differential Revision: D55078939

Copy link

pytorch-bot bot commented Mar 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2513

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 35c9718 with merge base 8f634a8 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • trunk / test-coreml-delegate / macos-job (gh)
    /Users/runner/work/executorch/executorch/pytorch/executorch/backends/apple/coreml/runtime/delegate/ETCoreMLModelManager.mm:387:43: error: no member named 'ModelPackage' in '(anonymous namespace)::ModelAssetType'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 19, 2024
Summary:
Pull Request resolved: pytorch#2513

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 19, 2024
Summary:
Pull Request resolved: pytorch#2513

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 19, 2024
Summary:
Pull Request resolved: pytorch#2513

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Differential Revision: D55078939
@mergennachin mergennachin self-requested a review March 20, 2024 01:50
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline in phabricator

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 20, 2024
Summary:
Pull Request resolved: pytorch#2513

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Reviewed By: mergennachin

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 20, 2024
Summary:

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Reviewed By: mergennachin

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 20, 2024
Summary:

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Reviewed By: mergennachin

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 20, 2024
Summary:

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Reviewed By: mergennachin

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 21, 2024
Summary:

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Reviewed By: mergennachin

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 21, 2024
Summary:

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Reviewed By: mergennachin

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 21, 2024
Summary:

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Reviewed By: mergennachin

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

Summary:

to_backend either takes partitioner or a dict of partitioner `key: method_name, value: partitioner`. We shouldn't do key as the backend name and value as the partitioner.

Reviewed By: mergennachin

Differential Revision: D55078939
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55078939

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c89a758.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants