Add support for SchemaKind.mutable to to_out_variant #2541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2541
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4475392 with merge base 634a206 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55156605 |
|
This pull request was exported from Phabricator. Differential Revision: D55156605 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 20, 2024
Summary: Pull Request resolved: pytorch#2541 Ideally custom mutator ops would not be in aten OpOverload but would instead be edge ops. The pass that results in mutator ops being in the graph is shared with core for now though and its hard to mix and match EP passes and GM passes. So just add the logic to the otherwise unused aten to_out_variant code. Reviewed By: larryliu0820 Differential Revision: D55156605
JacobSzwejbka
force-pushed
the
export-D55156605
branch
from
170178c to
ee5640d
Compare
larryliu0820
approved these changes
Mar 20, 2024
Summary: Pull Request resolved: pytorch#2541 Ideally custom mutator ops would not be in aten OpOverload but would instead be edge ops. The pass that results in mutator ops being in the graph is shared with core for now though and its hard to mix and match EP passes and GM passes. So just add the logic to the otherwise unused aten to_out_variant code. Reviewed By: larryliu0820 Differential Revision: D55156605
|
This pull request was exported from Phabricator. Differential Revision: D55156605 |
JacobSzwejbka
force-pushed
the
export-D55156605
branch
from
ee5640d to
4475392
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 21, 2024
Summary: Pull Request resolved: pytorch#2541 Ideally custom mutator ops would not be in aten OpOverload but would instead be edge ops. The pass that results in mutator ops being in the graph is shared with core for now though and its hard to mix and match EP passes and GM passes. So just add the logic to the otherwise unused aten to_out_variant code. Differential Revision: D55156605 Reviewed By: larryliu0820
|
This pull request has been merged in 8cf4d1f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Ideally custom mutator ops would not be in aten OpOverload but would instead be edge ops. The pass that results in mutator ops being in the graph is shared with core for now though and its hard to mix and match EP passes and GM passes. So just add the logic to the otherwise unused aten to_out_variant code.
Differential Revision: D55156605