Skip to content

Arm backend: Add and use ArmQuantizer #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Arm backend: Add and use ArmQuantizer #2561

wants to merge 1 commit into from

Conversation

oscarandersson8218
Copy link
Collaborator

  • Add and use ArmQuantizer in Arm backend.

@oscarandersson8218
Add ArmQuantizer
ac166c6 
- Add and use ArmQuantizer instead of XNNPACKQuantizer

Change-Id: I536d899e756675c1620435bdff7bdbe64b36aaea
Signed-off-by: Oscar Andersson <[email protected]>
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2561

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ac166c6 with merge base 8f634a8 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • trunk / test-coreml-delegate / macos-job (gh)
    /Users/runner/work/executorch/executorch/pytorch/executorch/backends/apple/coreml/runtime/delegate/ETCoreMLModelManager.mm:387:43: error: no member named 'ModelPackage' in '(anonymous namespace)::ModelAssetType'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2024
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Mar 21, 2024
digantdesai
digantdesai approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai
digantdesai reviewed Mar 21, 2024
View reviewed changes
backends/arm/test/tester/arm_tester.py
quantize_stage = Quantize(
XNNPACKQuantizer(),
ArmQuantizer(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 3152d7f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oscarandersson8218 @facebook-github-bot @digantdesai