Skip to content

Add Vulkan executor runner to Android JNIs #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 21, 2024

Copy link

pytorch-bot bot commented Mar 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2563

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 71a83fd with merge base 8f634a8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/periodic module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels Mar 21, 2024
SS-JIA added a commit that referenced this pull request Mar 21, 2024
ghstack-source-id: 31cf055
Pull Request resolved: #2563
Copy link

pytorch-bot bot commented Mar 21, 2024

Warning: Unknown label ciflow/periodic.
Currently recognized labels are

  • ciflow/nightly
  • ciflow/trunk
  • ciflow/binaries
  • ciflow/binaries/all

Please add the new label to .github/pytorch-probot.yml

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2024
@SS-JIA
Copy link
Contributor Author

SS-JIA commented Mar 21, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SS-JIA SS-JIA requested a review from kirklandsign March 21, 2024 16:46

add_library(executorch_llama_jni SHARED jni/jni_layer_llama.cpp)
target_link_libraries(executorch_llama_jni fbjni llama_runner
xnn_executor_runner_lib vulkan_executor_runner_lib)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we guard vulkan_executor_runner_lib under a flag?

@SS-JIA
Copy link
Contributor Author

SS-JIA commented Mar 21, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SS-JIA merged this pull request in 07eb609.

@SS-JIA SS-JIA deleted the gh/SS-JIA/25/head branch January 24, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants