add duplicate constant node pass #2570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2570
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 32b0898 with merge base c8f2d8d ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55113232 |
cccclai
force-pushed
the
export-D55113232
branch
from
abeff35 to
8fcee6a
Compare
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Mar 22, 2024
Summary: This diff is the follow up for pytorch#2424 In the case like ``` consant_0 (tag_10) ----> op_b (tag_10) |-------------> op_a (tag_11) ``` `op_b` and `op_a` are in two delegated payload and `constant_0` have two options: In this diff, we're making the default behavior as allowing copying, meaning it will become ``` consant_0 (tag_10)------------------> op_b (tag_10) consant_0_copy (tag_11) -------------> op_a (tag_11) ``` The backend can tag the node with `no_copy` to allert users in cases like constants are too large or etc. In this case, a better approach can be ``` consant_0 (tag_10) ----> op_b (tag_10) |-----(output consant_0) --------> op_a (tag_11) ``` Reviewed By: kirklandsign Differential Revision: D55113232
|
This pull request was exported from Phabricator. Differential Revision: D55113232 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Mar 22, 2024
Summary: This diff is the follow up for pytorch#2424 In the case like ``` consant_0 (tag_10) ----> op_b (tag_10) |-------------> op_a (tag_11) ``` `op_b` and `op_a` are in two delegated payload and `constant_0` have two options: In this diff, we're making the default behavior as allowing copying, meaning it will become ``` consant_0 (tag_10)------------------> op_b (tag_10) consant_0_copy (tag_11) -------------> op_a (tag_11) ``` The backend can tag the node with `no_copy` to allert users in cases like constants are too large or etc. In this case, a better approach can be ``` consant_0 (tag_10) ----> op_b (tag_10) |-----(output consant_0) --------> op_a (tag_11) ``` Reviewed By: kirklandsign Differential Revision: D55113232
cccclai
force-pushed
the
export-D55113232
branch
from
8fcee6a to
62de30d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55113232 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Mar 22, 2024
Summary: This diff is the follow up for pytorch#2424 In the case like ``` consant_0 (tag_10) ----> op_b (tag_10) |-------------> op_a (tag_11) ``` `op_b` and `op_a` are in two delegated payload and `constant_0` have two options: In this diff, we're making the default behavior as allowing copying, meaning it will become ``` consant_0 (tag_10)------------------> op_b (tag_10) consant_0_copy (tag_11) -------------> op_a (tag_11) ``` The backend can tag the node with `no_copy` to allert users in cases like constants are too large or etc. In this case, a better approach can be ``` consant_0 (tag_10) ----> op_b (tag_10) |-----(output consant_0) --------> op_a (tag_11) ``` Reviewed By: kirklandsign Differential Revision: D55113232
cccclai
force-pushed
the
export-D55113232
branch
from
62de30d to
76b2170
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55113232 |
angelayi
approved these changes
Mar 23, 2024
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Mar 24, 2024
Summary: This diff is the follow up for pytorch#2424 In the case like ``` consant_0 (tag_10) ----> op_b (tag_10) |-------------> op_a (tag_11) ``` `op_b` and `op_a` are in two delegated payload and `constant_0` have two options: In this diff, we're making the default behavior as allowing copying, meaning it will become ``` consant_0 (tag_10)------------------> op_b (tag_10) consant_0_copy (tag_11) -------------> op_a (tag_11) ``` The backend can tag the node with `no_copy` to allert users in cases like constants are too large or etc. In this case, a better approach can be ``` consant_0 (tag_10) ----> op_b (tag_10) |-----(output consant_0) --------> op_a (tag_11) ``` Reviewed By: angelayi Differential Revision: D55113232
cccclai
force-pushed
the
export-D55113232
branch
from
76b2170 to
69d8b43
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55113232 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Mar 24, 2024
Summary: This diff is the follow up for pytorch#2424 In the case like ``` consant_0 (tag_10) ----> op_b (tag_10) |-------------> op_a (tag_11) ``` `op_b` and `op_a` are in two delegated payload and `constant_0` have two options: In this diff, we're making the default behavior as allowing copying, meaning it will become ``` consant_0 (tag_10)------------------> op_b (tag_10) consant_0_copy (tag_11) -------------> op_a (tag_11) ``` The backend can tag the node with `no_copy` to allert users in cases like constants are too large or etc. In this case, a better approach can be ``` consant_0 (tag_10) ----> op_b (tag_10) |-----(output consant_0) --------> op_a (tag_11) ``` Reviewed By: angelayi Differential Revision: D55113232
cccclai
force-pushed
the
export-D55113232
branch
from
69d8b43 to
29c285c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55113232 |
Summary: This diff is the follow up for pytorch#2424 In the case like ``` consant_0 (tag_10) ----> op_b (tag_10) |-------------> op_a (tag_11) ``` `op_b` and `op_a` are in two delegated payload and `constant_0` have two options: In this diff, we're making the default behavior as allowing copying, meaning it will become ``` consant_0 (tag_10)------------------> op_b (tag_10) consant_0_copy (tag_11) -------------> op_a (tag_11) ``` The backend can tag the node with `no_copy` to allert users in cases like constants are too large or etc. In this case, a better approach can be ``` consant_0 (tag_10) ----> op_b (tag_10) |-----(output consant_0) --------> op_a (tag_11) ``` Reviewed By: angelayi Differential Revision: D55113232
cccclai
force-pushed
the
export-D55113232
branch
from
29c285c to
32b0898
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55113232 |
|
This pull request has been merged in 7f96f5a. |
|
@pytorchbot cherry-pick --onto release/0.2 |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot cherry-pick --onto release/0.2 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: #2570 This diff is the follow up for #2424 In the case like ``` consant_0 (tag_10) ----> op_b (tag_10) |-------------> op_a (tag_11) ``` `op_b` and `op_a` are in two delegated payload and `constant_0` have two options: In this diff, we're making the default behavior as allowing copying, meaning it will become ``` consant_0 (tag_10)------------------> op_b (tag_10) consant_0_copy (tag_11) -------------> op_a (tag_11) ``` The backend can tag the node with `no_copy` to allert users in cases like constants are too large or etc. In this case, a better approach can be ``` consant_0 (tag_10) ----> op_b (tag_10) |-----(output consant_0) --------> op_a (tag_11) ``` Reviewed By: angelayi Differential Revision: D55113232 fbshipit-source-id: 49559a8cc8225b866a399b4db04ef59fc6860cc1 (cherry picked from commit 7f96f5a)
Cherry picking #2570The cherry pick PR is at #2945 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is the follow up for #2424
In the case like
op_bandop_aare in two delegated payload andconstant_0have two options:In this diff, we're making the default behavior as allowing copying, meaning it will become
The backend can tag the node with
no_copyto allert users in cases like constants are too large or etc. In this case, a better approach can beDifferential Revision: D55113232