Skip to content

Add script to apply release-only changes #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Mar 21, 2024

Copy link

pytorch-bot bot commented Mar 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2578

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 959f497 with merge base ec6b88a (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2024
guangy10 added a commit that referenced this pull request Mar 21, 2024
ghstack-source-id: 9336ee9
Pull Request resolved: #2578
@guangy10
Copy link
Contributor Author

@huydhn Should we update the pinned pytorch to a released version, e.g. 2.3.0 in .ci/docker/ci_commit_pins/pytorch.txt? Otherwise how do we guarantee the executorch 0.2.0 will be compatible with 2.3.0?

@guangy10 guangy10 requested review from huydhn and mergennachin March 21, 2024 23:58
guangy10 added a commit that referenced this pull request Mar 22, 2024
ghstack-source-id: 05d72a2
Pull Request resolved: #2578
guangy10 added a commit that referenced this pull request Mar 22, 2024
ghstack-source-id: bd1fc8f
Pull Request resolved: #2578
@guangy10
Copy link
Contributor Author

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn
Copy link
Contributor

huydhn commented Mar 22, 2024

@huydhn Should we update the pinned pytorch to a released version, e.g. 2.3.0 in .ci/docker/ci_commit_pins/pytorch.txt? Otherwise how do we guarantee the executorch 0.2.0 will be compatible with 2.3.0?

This's a good idea, but I think let do that release-only in a separate PR for now. As I'm not quite sure what form it should looks like yet. I think it should just be changing the pinned commit to the branch release/2.3, but I suspect that the checkout logic needs to be updated accordingly.

Once we have that release-only change done once, we could figure out if it's possible to enhance this script to do that automatically.

@facebook-github-bot
Copy link
Contributor

@guangy10 merged this pull request in e7748f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants